setup_requires -> tests_requires, for pytest #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest>=5 isn't compatible with python2 https://github.com/pytest-dev/pytest/blob/eaf7ce9a992cea7506553b7d77fdf9622900ae36/setup.cfg#L43
jason-fugue
reviewed
May 7, 2021
Contributor
jason-fugue
left a comment
jason-fugue
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left a small question about tests_requires vs tests_require inline.
| setup_requires=[ | ||
| 'pytest>=5.4.1' | ||
| ], | ||
| tests_requires=tests_requires, |
Contributor
There was a problem hiding this comment.
Should this kw be tests_require?
Author
There was a problem hiding this comment.
it should, sorry this PR got buried
Author
|
Is this is still relevant? sorry, i get ~100 notifications a day and this got buried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest>=5 isn't compatible with python2 https://github.com/pytest-dev/pytest/blob/eaf7ce9a992cea7506553b7d77fdf9622900ae36/setup.cfg#L43
This makes the python2 version fail, even though it may be compatible, as noted: NixOS/nixpkgs#92561 (review)
For your CI, it looks like this is irrelevant because your tox.ini will install it anyway, and the
python setup.py testcommand is deprecated anyway.