feat(_put_file): dynamically adjust chunksize based on file size #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
dynamic=chunksize
branch
from
3682966 to
d73bf2b
Compare
Member
|
I am glad you are working on this. You may also be interested in fsspec/adlfs#508 , which implemented a coroutine pool rather than batching, a feature we could implement across fsspec ( @anjaliratnam-msft ). |
skshetry
force-pushed
the
dynamic=chunksize
branch
from
80ee9b3 to
ec57f88
Compare
`_put_file` will automatically increase the `chunksize` when uploading a large file to remain within 10,000 chunks limit.
skshetry
force-pushed
the
dynamic=chunksize
branch
from
83cbb47 to
429802e
Compare
skshetry
commented
Oct 28, 2025
Member
|
I am happy to merge if you are. I believe this must be untestable in moto, right? (edit: unless we patch the limits) |
Contributor
Author
Given that this logic only applies once the file size reaches >488 GiB, it isn’t testable with moto. I'd prefer not to patch the limits. I have refactored the chunksize calculation and added a unit test. |
Contributor
Author
|
@martindurant, would it be possible to cut a new release? |
Member
|
I'll do one in the next two days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_put_filewill automatically increase thechunksizewhen uploading a large file to remain within 10,000 chunks limit ifchunksizeis not set or isNone.Fixes #971.