Skip to content

Fix Traverse for Async seqs #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gusty
Copy link
Member

@gusty gusty commented Jun 10, 2025

The problem with the current implementation is that it ignores overloads defined in the custom IEnumerable.

Moreover, in these cases the resulting type is wrong:

> let b = traverse async.Return (MyCustomIEnumerable.ofSeq (Seq.initInfinite id))  ;;
val b: Async<int seq>   ===> it should be Async<int MyCustomIEnumerable>

@gusty
Copy link
Member Author

gusty commented Jun 12, 2025

This was reproduced here 917b669 and fixed at ba1d4ff

@gusty gusty closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant