Fix for large asynchronous writes. (too big for a single writev call)#3
Open
aarond10 wants to merge 14 commits intofrsyuki:masterfrom
Open
Fix for large asynchronous writes. (too big for a single writev call)#3aarond10 wants to merge 14 commits intofrsyuki:masterfrom
aarond10 wants to merge 14 commits intofrsyuki:masterfrom
Conversation
…ation. No functional change.
…ly wakes up one thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've fixed my issue with large MsgPack-RPC responses. After figuring out how your code works, I now unconditionally check m_out->has_queued() in the main event loop. I do not 100% follow your m_pollable logic though so I am a little concerned I may have broken some critical logic. Could you give this commit a look over and apply it if it seems sane. If you want me to revise it, just let me know how.