fix(named-inputs): match everything under a glob-free fileset path

[shaharkazaz]

Stacked on #98. Review only this branch's commit.

Problem

{workspaceRoot}/config compiled to a glob::Pattern matching only a file literally named config, not anything inside it; the trailing-slash form {workspaceRoot}/config/ matched nothing at all. So a sharedGlobals entry pointing at a directory silently never fired.

Solution

A glob-free entry now compiles to the literal and <path>/** (after stripping a trailing /), in both the Nx namedInputs path and the Turborepo globalDependencies path. Glob syntax includes braces, so {a,b} is never widened into a directory prefix. An empty path ({workspaceRoot}/) is skipped rather than widened to every file.

The code comment records two divergences from Nx that are left deliberately:

• require_literal_separator: false means * crosses /, so {workspaceRoot}/config/* selects more than Nx. Aligning means swapping the glob crate wholesale. Domino is knowingly wider.
• Nx's ! handling is not a target: feat(core): opt in to selecting affected tasks instead of projects nrwl/nx#36825 documents its extglob reading of ! as a bug pending its own fix.

Key changes

• src/named_inputs.rs: compile_global_pattern, has_glob_syntax, and GlobalPattern::directory: Option<Pattern>; matches_global_pattern ORs the directory pattern in.

Testing

• Red first: the three glob-free tests (Nx dir form, trailing slash, Turbo) failed at their first config/app.json assertion. The brace-set test was mutation-checked (fails with {/} removed from the glob-syntax set).
• Sibling paths (config.json, configs/app.json) do not match; an empty path matches nothing.
• Full suite, fmt and clippy pass on this branch alone.

Non-Nx workspaces

Turbo globalDependencies get the same expansion, and that matches Turborepo's own behaviour: its globwalk expands a metacharacter-free pattern that names a directory to dir/** (add_doublestar_to_dir in crates/turborepo-globwalk, mirrored in turborepo-scm). Rush and generic workspaces have no global-input config, so they are unaffected.

Breaking changes

None. Glob-free directory entries that previously matched nothing now match the directory's contents.

Sources

• Nx fileset semantics: feat(core): select affected tasks instead of affected projects nrwl/nx#36841 / #36825 (a_glob_free_path_matches_everything_under_it)
• Turborepo add_doublestar_to_dir: https://github.com/vercel/turborepo/blob/main/crates/turborepo-globwalk/src/lib.rs
• Turborepo globalDependencies docs: https://turborepo.dev/docs/reference/configuration

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

📦 Preview Release Available

A preview release has been published for commit fb1f42a.

Installation

npm install https://github.com/frontops-dev/domino/releases/download/pr-99-fb1f42a/front-ops-domino-2.0.2.tgz

Running the preview

npx https://github.com/frontops-dev/domino/releases/download/pr-99-fb1f42a/front-ops-domino-2.0.2.tgz affected

Details

• Release: pr-99-fb1f42a
• Direct URL: https://github.com/frontops-dev/domino/releases/download/pr-99-fb1f42a/front-ops-domino-2.0.2.tgz