Skip to content

Persist fallback titles for attachment-only threads #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tishmen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Persist fallback titles for attachment-only threads #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions src/composables/useDesktopState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4107,10 +4107,35 @@ export function useDesktopState() {
}
}

async function requestThreadTitleGeneration(threadId: string, prompt: string, cwd: string | null): Promise<void> {
function resolveFallbackThreadTitle(prompt: string, imageUrls: string[], fileAttachments: FileAttachment[]): string {
const trimmed = prompt.trim()
if (trimmed) return toOptimisticThreadTitle(trimmed)

const firstAttachmentLabel = fileAttachments
.map((attachment) => attachment.label.trim())
.find((label) => label.length > 0)
if (firstAttachmentLabel) return toOptimisticThreadTitle(firstAttachmentLabel)

if (imageUrls.length > 0) return toOptimisticThreadTitle('[Image]')
return 'Untitled thread'
}

async function requestThreadTitleGeneration(
threadId: string,
prompt: string,
cwd: string | null,
imageUrls: string[] = [],
fileAttachments: FileAttachment[] = [],
): Promise<void> {
if (threadTitleById.value[threadId]) return
const trimmed = prompt.trim()
if (!trimmed) return
if (!trimmed) {
const fallbackTitle = resolveFallbackThreadTitle(prompt, imageUrls, fileAttachments)
threadTitleById.value = { ...threadTitleById.value, [threadId]: fallbackTitle }
applyThreadFlags()
void persistThreadTitle(threadId, fallbackTitle)
return
}
const truncated = trimmed.length > 300 ? trimmed.slice(0, 300) : trimmed
try {
const title = await generateThreadTitle(truncated, cwd)
Expand Down Expand Up @@ -5021,7 +5046,7 @@ export function useDesktopState() {
.finally(() => {
isSendingMessage.value = false
})
void requestThreadTitleGeneration(capturedThreadId, capturedPrompt, capturedCwd)
void requestThreadTitleGeneration(capturedThreadId, capturedPrompt, capturedCwd, imageUrls, fileAttachments)
return threadId
} catch (unknownError) {
shouldAutoScrollOnNextAgentEvent = false
Expand Down