Merged
Conversation
pelargir
approved these changes
Sep 15, 2022
Collaborator
pelargir
left a comment
pelargir
left a comment
There was a problem hiding this comment.
Approved pending RuboCop fix.
The URI gem has changed its public API with this version, breaking compatibility with the largely unmaintained `data_uri` gem. This fixes the co-dependency issue for now; once this PR in `data_uri` is merged we can update to the newest `uri` gem: dball/data_uri#10
mamhoff
force-pushed
the
restrict-uri
branch
from
e0032e5 to
e93788a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URI gem has changed its public API with this version, breaking compatibility with the largely unmaintained
data_urigem. This fixes the co-dependency issue for now; once this PR indata_uriis merged we can update to the newesturigem:dball/data_uri#10