fix: reject invalid base64 binary values - #1816
Open
alethbedoyya-dot wants to merge 1 commit into
Open
alethbedoyya-dot wants to merge 1 commit into
alethbedoyya-dot wants to merge 1 commit into
Conversation
Use strict base64 decoding so string fields with the binary format reject non-alphabet characters instead of silently discarding them. Fixes frictionlessdata#1804.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StringFieldwithformat="binary"decoded values without strict validation.Python therefore discarded non-Base64 characters before checking padding, so
values such as
!!!!,@@@@, and()()were accepted as valid binary data.Enable strict decoding and add regression coverage for those inputs.
Fixes #1804.
Validation
hatch run spec— 1860 passed, 361 skipped, 28 deselected; 82.90% coveragehatch run type— 0 errors, 0 warningsruff check frictionless