Progress on #14#36
Open
lucas-deangelis wants to merge 2 commits intofreetonik:masterfrom
lucas-deangelis:master
Open
Progress on #14#36lucas-deangelis wants to merge 2 commits intofreetonik:masterfrom lucas-deangelis:master
lucas-deangelis wants to merge 2 commits intofreetonik:masterfrom
lucas-deangelis:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of some ideas of #14. I added a lint and a fmt command into the Makefile. fmt uses
go fmtand lint usesgolintandgo vet. I also resolved the issues raised by golint. Most of the comment added don't add much to the project aside from respectinggolint, but this PR means it's easier to see how #14 would affect Underblog.I also created a simple pre-commit hook with
make fmt && make lintbut I don't know how to share them across Github.