fix(detect): Lower occlusion threshold from 80% to 75%#219
Open
mlissner wants to merge 2 commits into
Open
Conversation
Some PDFs have black redaction bars that are 12pt tall while text spans are 14pt, giving ~79% occlusion per character. The 80% threshold rejected these. Lowering to 75% catches them while still filtering characters that barely clip a rectangle edge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Real-world filing where black bars are 12pt tall but text is 14pt. Also cleans up redundant changelog entries for same-release fixes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some PDFs have black redaction bars that are 12pt tall while text spans are 14pt, giving ~79% occlusion per character. The 80% threshold rejected these as "not enough overlap."
Lowering to 75% catches these while still filtering characters that barely clip a rectangle edge (the partial_intersections_ok test still passes at 0 chars).
Tested on this 24-page filing — goes from 0 to 16 detections.
Also cleans up redundant changelog entries (same-release feature + fix consolidated).
Test plan
test_low_occlusion_redactionwith trimmed real-world PDFtest_ignoring_partial_occlusionsstill passes (0 chars)🤖 Generated with Claude Code