1530 implement site wide scraping limit#1696
Open
Luis-manzur wants to merge 5 commits intomainfrom
Open
Conversation
for more information, see https://pre-commit.ci
…g-limit' into 1530-implement-site-wide-scraping-limit
Contributor
|
We definetly don't want so many new base classes. It should be either a Mixin the user imports and uses as parent when defining a child scraper; or a flag that triggers code as we do most things in AbstractSite. This PR may have some useful code, I will put this in the backlog for future checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Addresses #1530
to test this pick up any site and inherit from
OpinionSiteRateLimitedorOpinionSiteLinearRateLimitedand add theRATE_LIMIT_CONFIG