libpkg cleanups #2523
Merged
libpkg cleanups #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change intended.
No functional change intended.
While here, fix some style bugs. No functional change intended.
No functional change intended.
This lets us deindent some code. Wrap some long lines while here. No functional change intended.
Instead of having two confusingly named helper functions to determine whether a package with a given name is installed, collapse them into one. No functional change intended.
pkgdb_it_next() will handle freeing the pkg structure.
It's not implemented by the ASAN runtime on FreeBSD and configuring it causes a message to that effect to be printed, causing all tests to fail due to unexpected output on stderr.
No functional change intended.
No functional change intended.
arrowd
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next PR will contain some actual functional changes. Just submitting these separately in advance.