Fix pkg -r <rootdir> check
#2519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change intended.
We should skip over all the leading slashes, not just the first one. It's very conceivable that some bug or misconfiguration results in package file paths with multiple leading slashes, and *at(rootfd, "/foo") ignores rootfd so this could have "fun" consequences.
This would have caught a bug where pkg-check failed to respect the rootdir.
uname -r fetches the kernel version, but really it makes more sense to check the userspace version. Otherwise these tests fail spuriously when run on a system running a 16-CURRENT kernel and 15.0-PRERELEASE userspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some assorted cleanups and a new regression test.