libpkg: Support system triggers #2516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: https://reviews.freebsd.org/D52564 |
|
Can't hold myself from a little bikeshedding - maybe call these things "base triggers" and "localbase triggers"? Or would that be too FreeBSD-specific? |
|
we should turn the triggers_dir into an array like every path |
that seems reasonable and would also address Gleb's comment, i'll rework the patch. |
Add support for system triggers installed in /usr/share/pkg/triggers, not under PREFIX. This will be used for the FreeBSD base system. For compatibility, keep the existing trigger config PKG_TRIGGERS_DIR, but turn it into a list and add /usr/share/pkg/triggers to the default value.
|
Thanks! I should have implemented triggers this way day 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for system triggers installed in /usr/share/pkg/triggers, not under PREFIX. This will be used for the FreeBSD base system.