Feat/i18n german translations #2754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap sidebar labels in __() translation function - Convert sidebar options to computed properties for runtime translation - Add German translations for: - Navigation items (Search, Dashboard, Notifications, Help) - Sidebar controls (Collapse, Expand) - Main menu items (Tickets, Knowledge Base, Canned responses, Customers, Contacts, Call Logs) - Customer page labels (New customer, No Customers Found) - Update de.po locale file with all new translations This ensures translations are evaluated at runtime when window.translatedMessages is available from the backend API.
- Add translationsLoaded ref to track when translations are available - Update translate() function to access translationsLoaded.value, creating reactive dependency - Add missing translations to Customers.vue page - Ensures computed properties re-evaluate when translations are loaded from backend This fixes the issue where sidebar menu items and customer page labels remained in English even though translations were present in de.po
- Create useTranslation composable that wraps translations in computed - Update Sidebar.vue to use reactive translations via useTranslations() - Update MobileSidebar.vue to use reactive translations - Ensures ALL translations (including template-level ones) re-evaluate when loaded This fixes the issue where some translations (Search, Notifications, Help, Collapse/Expand) remained in English because they were evaluated before translationsLoaded signal was set. Now all translations are wrapped in computed properties that reactively depend on translationsLoaded.
- Keep placeholder hardcoded in English: 'Search or type # to go to ticket' - Remove tSearchPlaceholder reactive translation - Remove placeholder translation from de.po - Keep all other translations working (Jump to, Tickets, Knowledge Base, etc.) Placeholder translation in input elements doesn't work reliably with HeadlessUI ComboboxInput component. Rest of the dialog translations work correctly and are kept.
- Replace __() function with useTranslation composable for reactive translations - Update components: CannedResponses, Contacts, Customers, KnowledgeBase, CallUI, EmptyState - Add German translations for HD Customer and HD Article DocType labels - Translate standard DocType fields (Created On, Modified, Customer Name, etc.) - Ensure UI updates when translations load asynchronously
- Make DiscardButton translations reactive with useTranslation composable - Add reactive column label translations in ListViewBuilder - Translate TextEditor discard button - Add search placeholder translation to command palette - Implement reactive translations in TicketNew form - Add 33 new German translations to de.csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to get the helpdesk/tickets view translated, at many places Translations have not been integrated yet, this should fix most places. Not sure if this is the way to go, i would be thankful for feedback on this.