Modify TestAppExample to add service#282
Open
KangLin wants to merge 1 commit into
Open
Conversation
|
|
||
| void KeyChainClass::setService(const QString &service) | ||
| { | ||
| if(m_readCredentialJob) delete m_readCredentialJob; |
Owner
There was a problem hiding this comment.
don't do if (foo) delete foo, the if isn't necessary as deleting a nullptr is safe.
| if(m_writeCredentialJob) delete m_writeCredentialJob; | ||
| if(m_deleteCredentialJob) delete m_deleteCredentialJob; | ||
|
|
||
| m_readCredentialJob = new QKeychain::ReadPasswordJob(service, this); |
Owner
There was a problem hiding this comment.
I need to check all the implementations, but I see no strict reason why there shouldn't be a setService() setter... then this patch would become a lot simpler/ smaller.
Owner
There was a problem hiding this comment.
Nevermind, the code changed already to dynamic jobs anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.