[WIP] Fixing method Phone.validate_phone adding some comments in readme.md#1
Open
franciscoprin wants to merge 2 commits into
Open
[WIP] Fixing method Phone.validate_phone adding some comments in readme.md#1franciscoprin wants to merge 2 commits into
franciscoprin wants to merge 2 commits into
Conversation
franciscoprin
changed the title
franciscoprin
commented
Sep 25, 2020
franciscoprin
left a comment
franciscoprin
left a comment
Owner
Author
There was a problem hiding this comment.
@carlosvivasb and @Anahis259 could you 👀 this, please.
Comment on lines
+9
to
+10
| # if phone_is_invalid: | ||
| # print("Your phone number is invalid.") |
Owner
Author
There was a problem hiding this comment.
Oops, it seems that I had made a small mistake here, could you uncomment these lines, please.
Comment on lines
+16
to
+19
| if self.phone_letters: | ||
| if self.phone_letters[0] == "+" and len(self.phone_letters) < 15: | ||
| return True | ||
| return False |
Owner
Author
There was a problem hiding this comment.
This is the required code to fix the unit test. More work is required here to fix the test_validate_phone_doesnt_allow_special_characters
Anahis259
approved these changes
Sep 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing tests.