Skip to content

Browser & persistent authentication support聽#36

Description

@cdloh

Hi @foxt 馃憢

Love the project and your work here. I was really interested in adding web support to the lilbrary and persistent authentication.

I'd like to use the Library in Obsidian which is built on Electron. I was planning on adding the following functionality.

  1. Add persistent authentication support to AuthStore (store the various cookies etc on the FS)
    Have to handle session expiry as well.

  2. Extend AuthStore to be able to have a few different stores
    For web support I would create one that used LocalStorage

  3. Rework remaining NodeJS requirements

Would you be interested in adding this functionality? I'm happy to do this work but want to check before doing the work.

Activity

  1. foxt commented on May 8, 2025

    @foxt
    Owner

    Hi, supporting browser use is an interesting possibility, however, wouldn't CORS cause issues?

    FWIW: I was planning a rewrite for more modularity (including being able to provide your own handlers for network & persistence) however I haven't had chance to actually write much code for it. I'll see if I can sit down with it and get something to show for it

  2. cdloh commented on May 8, 2025

    @cdloh
    Author

    It wouldn't be true browser support (at least for my use case) as Obsidian puts wrappers around fetch to get around CORS issues. You are correct in there being cors issues but most people disable it in Electron apps AFAIK.

    If you're looking at making it more modular that would be excellent. I'm mainly looking at just interacting with the Apple Photos for embedding support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions