Implement maddy_queue_length metric #780
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spiarh <[email protected]>
The maddy_queue_length was already registered but never used. The gauge is updated when actions on disks are performed: - Incremented when a message is written to disk or when the queue is read from disk. - Decremented when a message is removed from disk. Signed-off-by: spiarh <[email protected]>
|
@foxcpp could you please take a look? that should be pretty quick to review ;) |
|
@foxcpp sorry for the late reply, the tests may be a bit flaky. I did run the tests successfully on master and on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maddy_queue_length was already registered but never used.
The gauge is updated when actions on disks are performed:
is read from disk.