Skip to content

Complete rewrite #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Complete rewrite #38

wants to merge 1 commit into from

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Jun 27, 2025

Complete rewrite of dissect.vmfs, this time entirely from my own reverse engineering and nothing from vmfs-tools, which has caused so many problems in the first implementation.

LVM has pretty complete tests already, and I recommend the reviewer to review LVM and VMFS separately.

Unit tests for VMFS will follow later.

Closes #37.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 84.14747% with 172 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (f985a0f) to head (a64052f).

Files with missing lines Patch % Lines
dissect/vmfs/descriptor.py 86.21% 51 Missing ⚠️
dissect/vmfs/resource.py 71.26% 50 Missing ⚠️
dissect/vmfs/address.py 76.04% 46 Missing ⚠️
dissect/vmfs/lvm.py 91.75% 16 Missing ⚠️
dissect/vmfs/vmfs.py 95.12% 6 Missing ⚠️
dissect/vmfs/util.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   77.47%   84.72%   +7.25%     
==========================================
  Files           6       10       +4     
  Lines         688     1152     +464     
==========================================
+ Hits          533      976     +443     
- Misses        155      176      +21     
Flag Coverage Δ
unittests 84.72% <84.14%> (+7.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Second level directory open in large-capacity VMFS6 file system got wrong
1 participant