Remove unneded feature flags in tests#4295
Open
MKowalski8 wants to merge 5 commits intomasterfrom
Open
Conversation
MKowalski8
changed the title
piotmag769
reviewed
Apr 20, 2026
MKowalski8
force-pushed
the
mkowalski/remove-unused-features-flags
branch
2 times, most recently
from
f3cdc77 to
c0cf5b3
Compare
MKowalski8
changed the base branch from
master
to
mkowalski/bump-scarb-to-2.18.0
piotmag769
reviewed
Apr 22, 2026
piotmag769
reviewed
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Also one general note, isn't this pattern #[cfg_attr(not(feature = "some_feature"), ignore)] a bit convoluted?
I would do #[cfg(feature = "some_feature")] and get the same result - unless you really need the info about ignored test in cargo test output
MKowalski8
force-pushed
the
mkowalski/bump-scarb-to-2.18.0
branch
from
e495d8f to
a1a6f70
Compare
MKowalski8
force-pushed
the
mkowalski/remove-unused-features-flags
branch
from
c0cf5b3 to
374bd8c
Compare
piotmag769
approved these changes
Apr 23, 2026
MKowalski8
force-pushed
the
mkowalski/remove-unused-features-flags
branch
3 times, most recently
from
4a0f5c7 to
96c30bb
Compare
MKowalski8
commented
Apr 27, 2026
| - name: Run snap E2E tests | ||
| run: cargo test --profile ci -p forge --test main snap_ | ||
|
|
||
| test-plugin-checks: |
Contributor
Author
There was a problem hiding this comment.
Since the plugin is already covered by the e2e tests and the test_for_multiple_scarb_versions flag appeared to be a redundant leftover, I merged the special condition tests into a single job.
We can think of moving it only to scheduled tests. But for example mayby it's good to know as fast as possible if the backward compatibility with snforge new is broken.
MKowalski8
commented
Apr 27, 2026
|
|
||
| #[test] | ||
| #[cfg_attr( | ||
| feature = "skip_test_for_only_latest_scarb", |
Contributor
Author
There was a problem hiding this comment.
Those tests pass without it. So imo there is no reason to keep it. If something brake in the future we can just simply add it back.
MKowalski8
force-pushed
the
mkowalski/remove-unused-features-flags
branch
from
04be695 to
9acb1c2
Compare
MKowalski8
force-pushed
the
mkowalski/remove-unused-features-flags
branch
from
9acb1c2 to
82adec9
Compare
franciszekjob
approved these changes
Apr 28, 2026
MKowalski8
force-pushed
the
mkowalski/remove-unused-features-flags
branch
from
82adec9 to
9450510
Compare
ddoktorski
approved these changes
Apr 28, 2026
| echo "features=$FEATURES" >> "$GITHUB_OUTPUT" | ||
| - name: Build and archive tests | ||
| run: cargo nextest archive --cargo-profile ci -p forge --features "${{ steps.test_features.outputs.features }}" --archive-file 'nextest-archive-forge-native-${{ runner.os }}.tar.zst' | ||
| run: cargo nextest archive --cargo-profile ci -p forge --features "cairo-native" --archive-file 'nextest-archive-forge-native-${{ runner.os }}.tar.zst' |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| run: cargo nextest archive --cargo-profile ci -p forge --features "cairo-native" --archive-file 'nextest-archive-forge-native-${{ runner.os }}.tar.zst' | |
| run: cargo nextest archive --cargo-profile ci -p forge --features cairo-native --archive-file 'nextest-archive-forge-native-${{ runner.os }}.tar.zst' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #4091
Introduced changes
e2eChecklist
CHANGELOG.md