fix(evm): align local create2 setup with configured deployer#14016
Open
ArshLabs wants to merge 2 commits intofoundry-rs:masterfrom
Open
fix(evm): align local create2 setup with configured deployer#14016ArshLabs wants to merge 2 commits intofoundry-rs:masterfrom
ArshLabs wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
Member
|
Hi @ArshLabs, thanks for your fix! This is a sensitive code path so I would like to see additional tests for it for |
Author
Added the requested forge test coverage for custom CREATE2 deployer in both local and forked paths, and pushed the update. Both new tests pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When
create2_deployeris customized, local setup currently checks or deploys only the default deployer address, while CREATE2 execution uses the inspector-configured address. This can make setup and runtime target different addresses and lead tomissing CREATE2 deployerreverts even though setup already ran.Solution
deploy_create2_deployernow resolves the deployer address from the executor inspector, so setup and runtime CREATE2 execution use the same address.Behavior by case:
A regression test is added for
forge scriptno-endpoint execution with--create2-deployerto verify custom deployer setup aligns with runtime behavior.PR Checklist