fix(evm): query state_snapshot.storage in ForkDbStateSnapshot::storage_ref#14007
Open
gutonosa wants to merge 2 commits intofoundry-rs:masterfrom
Open
fix(evm): query state_snapshot.storage in ForkDbStateSnapshot::storage_ref#14007gutonosa wants to merge 2 commits intofoundry-rs:masterfrom
state_snapshot.storage in ForkDbStateSnapshot::storage_ref#14007gutonosa wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
gutonosa
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForkDbStateSnapshot::storage_refwas skippingstate_snapshot.storageentirely. The lookup path went fromlocal.cachestraight to the remote RPC backend, missing any storage data thatSharedBackendhad previously fetched and persisted in theBlockchainDb. This caused stale or incorrect values to be returned when reverting to a state snapshot, since the RPC would return current on-chain state rather than the snapshotted state.aligns
storage_refwithbasic_ref, which already queriesstate_snapshotas the second lookup layer. Replaced the redundantget_storage()helper (which only re-checkedlocal.cache) withstorage_from_snapshot_or_backend(), giving the correct lookup order:local.cache→state_snapshot.storage→SharedBackend/ RPC.