fix(traces): decode expectRevert payload before revert formatting#13981
Open
ArshLabs wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(traces): decode expectRevert payload before revert formatting#13981ArshLabs wants to merge 1 commit intofoundry-rs:masterfrom
ArshLabs wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
expectReverttrace formatting currently feeds full cheatcode calldata intoRevertDecoder, instead of decoding the cheatcode input first and passing only the expected-revert payload. This can produce misleading trace output.Solution
Decode
expectRevertinputs first inCallTraceDecoder::decode_cheatcode_inputs, then pass the decoded expected-revert bytes (bytesorbytes4) intoRevertDecoder.Added local decoder test coverage in the same module for:
expectRevert(bytes4)expectRevert(bytes)expectRevert()fallback behaviorValidation performed:
cargo +nightly fmt -- --checkcargo test -p foundry-evm-tracescargo check --allcargo +nightly clippy -p foundry-evm-traces --all-targets -- -D warningscargo test --all --all-features(currently fails in this environment attracy-client-sys, unrelated to touched code)AI disclosure: I used AI assistance for basic code navigation, then did drafting & manually verified the implementation and test behavior.
PR Checklist