feat(cheatcodes): extend usable range in assertApproxEqRel
#10758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeb
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
zerosnacks
reviewed
Jun 11, 2025
|
@zerosnacks let me add an overflow test quickly, I noticed it's missing |
zerosnacks
approved these changes
Jun 11, 2025
|
cc @klkvr would you mind double checking this proposed change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For large values, the current implementation of the cheatcode
assertApproxEqReloverflows during calculation of the relative delta. However, using a larger type for this calculation allows to prevent overflows and use the full range ofuint256.Solution
The calculation was modified to use
U512for the calculation and only check that the final value for the delta fits inside auint256(a requirement of the error type).PR Checklist