Adds delete revision option for admin
#56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyushDharDubey
commented
Aug 29, 2025
lonvia
reviewed
Aug 29, 2025
| if not revision: | ||
| models = Model.objects.filter(model_id=model_id) | ||
| else: | ||
| models = Model.objects.filter(model_id=model_id, revision=revision) |
There was a problem hiding this comment.
I see a few corner cases here:
-
if the latest revision is deleted, then the previous one needs to become latest.
-
If the last available revision is deleted, the model is gone. If it wasn't the last revision it is still there.
Are these covered through automatic updates? Can we maybe have tests for that?
There was a problem hiding this comment.
No I missed these, I will overwrite the model's delete method to handle latest and write tests to ensure.
Most probably not. I have not seen any. |
instead of the whole model folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54
This PR introduces
Delete Revisionfeature when the admin is on page/model/<model_id>/<revision>; and continues showingDelete Modeloption when the admin is on page/model/<model_id>instead.