Use rglob instead of glob for recursive OBJ file search #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous version of obj2glb script was throwing errors for 12 model instances, this version is effectively converting 10 of them. Although this version produces gltf binary for the model_id 40 without errors, but, these two glb files are not being rendered properly on the frontend. It is possible that these specific 2 files are broken, and may be deleted. Other 10 models are rendering fine. |
AyushDharDubey
deleted the
fix/issue_54-search-for-obj-files-recursively
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corresponds to the issue as discussed in #54.
This PR updates obj2glb management script to search for OBJ files recursively in the zip to address some outlier models having subdirectory inside model zip.