Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Fix #320: Improve greetings handling#398

Open
Pittu-Sharma wants to merge 1 commit into
fossasia:masterfrom
Pittu-Sharma:patch-12
Open

Fix #320: Improve greetings handling#398
Pittu-Sharma wants to merge 1 commit into
fossasia:masterfrom
Pittu-Sharma:patch-12

Conversation

@Pittu-Sharma
Copy link
Copy Markdown

@Pittu-Sharma Pittu-Sharma commented Feb 27, 2026

Added proper responses for informal and formal greetings.
Fixes issue #320.

Summary by Sourcery

New Features:

  • Add support for distinguishing and responding to informal versus formal English greetings.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the English greetings configuration to distinguish between and respond appropriately to informal and formal greetings, addressing the behavior described in issue #320.

File-Level Changes

Change Details Files
Refine greetings handling to support distinct informal and formal responses.
  • Adjust the greetings data set to classify greetings by formality level
  • Add or update responses to match informal vs. formal greeting variants
  • Ensure existing generic greetings remain compatible with the new handling
models/general/Communication/en/Greetings.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant