Skip to content

Conversation

@Tejasgarg
Copy link
Contributor

@Tejasgarg Tejasgarg commented Oct 2, 2025

This PR fixes Q1, Q2 footprint, linking it to the correct one.
It also adds the required 3d model for the SOT-416 package.

Summary by Sourcery

Fix the transistor footprints for Q1 and Q2 and provide the missing SOT-416 package files

Bug Fixes:

  • Correct the footprints for Q1 and Q2 to use the proper package

Enhancements:

  • Add 3D model for SOT-416 package
  • Introduce SOT-416 footprint file in the PCB library

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes issue #56 by correcting Q1 and Q2 to use the proper SOT-416 footprint and introduces the new SOT-416 footprint definition and corresponding 3D model for the SMMBT3904TT1G device.

File-Level Changes

Change Details Files
Correct Q1/Q2 footprints to SOT-416
  • Updated schematic symbol footprint fields for Q1 and Q2
  • Adjusted PCB footprint assignments for Q1 and Q2
schematic/pslab-mini.kicad_sch
schematic/pslab-mini.kicad_pcb
Add SOT-416 footprint definition and 3D model
  • Added new SOT-416.kicad_mod footprint file
  • Added SMMBT3904TT1G.stp 3D model file
  • Linked the 3D model to the SOT-416 footprint
schematic/pslab-mini.pretty/SOT-416.kicad_mod
schematic/3DModels/SMMBT3904TT1G.stp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Layout Previews for 36f7504
Front Copper Front Silk
Front Copper Front Silk
Bottom Copper Bottom Silk
Bottom Copper Bottom Silk
Front Mask Bottom Mask
Front Mask Bottom Mask
Diff Previews for 36f7504
Front Copper Diff Front Silk Diff
Front Copper Diff Front Silk Diff
Bottom Copper Diff Bottom Silk Diff
Bottom Copper Diff Bottom Silk Diff
Front Mask Diff Bottom Mask Diff
Front Mask Diff Bottom Mask Diff

@Tejasgarg Tejasgarg requested a review from CloudyPadmal October 2, 2025 07:36
@CloudyPadmal CloudyPadmal merged commit 9b70d3f into fossasia:main Oct 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Q1, Q2 Footprint

2 participants