-
Notifications
You must be signed in to change notification settings - Fork 2
PR 2: Add Data Model (CPTs, Taxonomies, Meta Fields) #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NishilHoogar
wants to merge
16
commits into
fossasia:main
Choose a base branch
from
NishilHoogar:pr-2-data-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-1 introduces a minimal, activatable WordPress plugin skeleton for FOSSASIA Landing. Includes: - Main plugin file with WP header and security check - Loader class for modular future expansion - Minimal README Feature logic, CLI, uninstaller, and templates are excluded to keep this PR reviewable.
- Moved run_fossasia_landing() from global scope to FOSSASIA_Landing_Loader::run_plugin() - Hooked initialization to plugins_loaded for proper WordPress lifecycle - Aligns PR-1 with WordPress and modern PHP best practices
- Added wpfaevent.php bootstrap and loader/core classes - Introduced admin/public stubs and partials - Moved templates into partial proxies - Added uninstall script and PHPCS workflow - Preserved legacy logic for compatibility
…public, includes, languages), reorganized assets, and cleaned redundant files Refactored plugin layout to align with WordPress Plugin Boilerplate; added standard directories and removed redundant files
- Reviewed and restored the original boilerplate structure as per feedback. - Moved loader file to the includes/ directory following WordPress plugin conventions. - Renamed includes/class-fossasia-uninstaller.php to includes/class-wpfaevent-uninstaller.php for consistency. - Verified and aligned overall directory and class structure with the standard WordPress plugin layout. - Integrated fossasia-landing.php logic into the main plugin flow: - Added an initialize_fossasia_landing() method inside the loader. - Safely included fossasia-landing.php within wpfaevent.php without disrupting existing bootstrap or comments. - Ensured all original comments and metadata remain intact.
…ent consistency This update removes direct inclusion of the old fossasia-landing.php file from the main plugin bootstrap and aligns all references to the standardized wpfaevent naming convention. The landing page logic has been modularized into a dedicated class file (includes/class-wpfaevent-landing.php) and is now initialized properly through WordPress hooks for better structure and maintainability. Key Changes: Removed direct fossasia-landing references and renamed related files, templates, and class mentions to use the wpfaevent prefix. Added initialize_wpfaevent_landing() method inside the loader to handle landing setup via the plugins_loaded hook. Updated require_once statements to use plugin_dir_path( __FILE__ ) for proper modular path resolution. Verified that no root-level files are directly included from /includes/ or /public/. Ensured plugin initialization logic runs through WordPress hooks instead of executing on file load. Checked structure integrity after restoring the boilerplate and ensuring class closures were correctly placed.
Removed remaining fossasia-landing references and renamed related files. Eliminated duplicate templates from /templates/ and kept consistent copies under /public/partials/. Retained only root-level uninstall.php file. Moved CSS/JS files to appropriate directories (public/css/, admin/css/). Relocated misplaced PHP files to /includes/. Verified proper plugin bootstrap through loader hooks (plugins_loaded).
- Renamed or removed remaining fossasia-landing-* templates to wpfaevent-* for consistency. - Consolidated duplicate templates under public/partials/ and removed redundant ones from templates/. - Retained only root uninstall.php (removed templates/uninstall.php). - Moved stylesheet files to correct directories: • wpfaevent-admin.css → admin/css/ • wpfaevent-public.css → public/css/ Updated corresponding enqueue paths. - Verified that plugin initialization is fully hook-based via plugins_loaded with no direct execution at file load. - Preserved all original comments and documentation blocks unchanged. This update completes all pending checklist items for review and aligns the plugin structure with WordPress best practices.
-Moved PHP classes to includes/ -Removed duplicate templates, kept canonical in public/partials/ -Verified template includes, require_once paths, and text domain -Confirmed .github/workflows/ has only YAML files -Checked enqueue paths for CSS/JS -All comments preserved, no functional changes beyond restructuring
Moved remaining template files to their canonical locations and updated include paths accordingly. Retained the existing approach for speakers-page-content.php as it is intended for internal plugin use only.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @NishilHoogar, your pull request is larger than the review limit of 150000 diff characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2: Add Data Model (CPTs, Taxonomies, Meta Fields)
Summary
This pull request implements the backend data model for the WPFAevent plugin as requested in PR Task 2. The changes are strictly backend-only and build on the existing PR-1 boilerplate.
Scope
Included:
Taxonomies
Meta Fields
Integration
-tests/test-meta-registration.php
Not included
Notes
This PR focuses solely on the backend data model and follows existing naming conventions and coding standards in the project.
All additions are intentionally minimal and scoped to avoid conflicts and maintain the plugin identity.