Skip to content

[VULN-59766] Remove direct dependency on github.com/docker/docker v28#3

Closed
L3n41c wants to merge 3944 commits intofossabot:masterfrom
DataDog:lenaic/VULN-59766-remove-docker-docker-v28-dependency
Closed

[VULN-59766] Remove direct dependency on github.com/docker/docker v28#3
L3n41c wants to merge 3944 commits intofossabot:masterfrom
DataDog:lenaic/VULN-59766-remove-docker-docker-v28-dependency

Conversation

@L3n41c
Copy link
Copy Markdown

@L3n41c L3n41c commented Apr 2, 2026

Summary

  • Remove direct github.com/docker/docker imports by replacing HostConfigModifier callbacks with AutoRemove: true on testcontainers.ContainerRequest
  • Upgrade google/go-containerregistry from v0.20.7 to v0.21.3 (which migrated to moby/moby sub-modules)
  • Add replace directive for the remaining indirect dependency, redirecting to the patched 28.x branch of moby/moby (security fixes for authz body size limit and plugin privilege validation)

Context

Jira tickets: VULN-59766, VULN-59767, VULN-59774, VULN-59775, CONTINT-5217, CONTINT-5218, CONTINT-5219, CONTINT-5220

Related: DataDog/datadog-agent#48777

Note

After merging, run go mod tidy (with GOEXPERIMENT=jsonv2) to finalize go.sum cleanup. The indirect dependency on docker/docker cannot be fully removed from go.mod until testcontainers-go and other transitive dependencies migrate to moby/moby sub-modules upstream.

Test plan

  • go mod tidy completes successfully
  • go build ./... compiles without errors
  • Integration tests with //go:build integration still pass
  • Verify go.sum references moby/moby pseudo-version instead of docker/docker v28.5.2

🤖 Generated with Claude Code

DmitriyLewen and others added 30 commits September 15, 2025 07:21
Co-authored-by: knqyf263 <knqyf263@users.noreply.github.com>
Co-authored-by: nikpivkin <nikita.pivkin@smartforce.io>
Co-authored-by: DmitriyLewen <dmitriy.lewen@smartforce.io>
…h vulnerability updates (#9439)

Signed-off-by: knqyf263 <knqyf263@gmail.com>
Co-authored-by: DmitriyLewen <dmitriy.lewen@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Co-authored-by: DmitriyLewen <dmitriy.lewen@smartforce.io>
…497)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Co-authored-by: DmitriyLewen <91113035+DmitriyLewen@users.noreply.github.com>
… (#9507)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DmitriyLewen <91113035+DmitriyLewen@users.noreply.github.com>
…ably (#9302)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
…FindInMap (#9515)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Co-authored-by: DmitriyLewen <dmitriy.lewen@smartforce.io>
Co-authored-by: knqyf263 <knqyf263@users.noreply.github.com>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
…pfs and testing/fstest (#9282)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Co-authored-by: knqyf263 <knqyf263@gmail.com>
dependabot bot and others added 29 commits January 30, 2026 10:57
…0068)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DmitriyLewen <dmitriy.lewen@smartforce.io>
…10103)

Co-authored-by: GitHub Actions <actions@github.com>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: Carlos Rodríguez Hernández <carlos.rodriguez-hernandez@broadcom.com>
…e attributes (#10128)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
…nore (#10112)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
…10155)

Co-authored-by: GitHub Actions <actions@github.com>
…#10179)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
… (#10206)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: yusuke.koyoshi <yusuke.koyoshi@assured.inc>
…er/docker v28

Remove the direct dependency on github.com/docker/docker v28 which has
known security vulnerabilities in authz and plugin packages.

- Replace HostConfigModifier callbacks with the equivalent AutoRemove
  field on testcontainers.ContainerRequest in all integration tests
- Upgrade google/go-containerregistry from v0.20.7 to v0.21.3, which
  migrated from docker/docker to moby/moby sub-modules
- Bump transitive dependencies required by go-containerregistry v0.21.3
  (docker/cli, moby/moby/api, moby/moby/client, golang.org/x/*)
- Add replace directive redirecting the remaining indirect docker/docker
  dependency to moby/moby 28.x branch (commit 31a1689c) which contains
  the security fixes (authz body size limit, plugin privilege validation)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@L3n41c L3n41c closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.