stdlib_system: essential path functionality
#999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @wassup05. Just a minor point (not related to functionality) about examples for now: It's always useful - esp. for those learning by examples - to have an idea of the expected output. Other stdlib examples add the expected print results as a comment below the respective commands. I would recommend to do the same here. |
|
I will add that with the other reviews @sebastian-mutz, I don't want to trigger the ci/cd workflow just for a few comments. Also on a second thought maybe instead of the |
jalvesz
reviewed
Jun 12, 2025
example/system/example_path_1.f90
Outdated
There was a problem hiding this comment.
I would advise to split the example per function such that each function in the specs gets it's own code snippet.
wassup05
commented
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few path related functions for ease of future functionality have been added.
joinpath: joins the given paths according to the platform'spath-separator.operator(/): as was suggested in the Fortran discourse here an operator is also provided for the same functionalitysplitpath: splits the path following the lastpath-separatorand returns theheadandtail.basename: just returns thetailofsplitpathdirname: just returns theheadofsplitpathThe
pathsepparametercontains either/or\depending on the platform and is a compile-time constant now, so is theparameter,ISWINDo let me know your thoughts.