Fix AttributeError when parsing a credential with auth data#2219
Open
eugen-goebel wants to merge 1 commit into
Open
Fix AttributeError when parsing a credential with auth data#2219eugen-goebel wants to merge 1 commit into
eugen-goebel wants to merge 1 commit into
Conversation
Credential.authData was initialized as a tuple and never turned into a list before the parse loop appended to it, so any ccache credential carrying authorization data raised "AttributeError: 'tuple' object has no attribute 'append'". Initialize it as a list right before the loop, mirroring how addresses is already handled. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Credential.authDatais initialized as a tuple()and, unlikeaddresses, is never reassigned to a list before the parse loop runsself.authData.append(ad). Parsing any ccache credential that carries authorization data therefore raises:AttributeError: 'tuple' object has no attribute 'append'(inCredential.__init__,impacket/krb5/ccache.py).Closes #2119.
Fix
Initialize
self.authData = []right before the auth-data loop, mirroring the existingself.addresses = []line a few lines above. Note: the issue also mentionsaddresses, but that attribute is already reassigned to a list before its own loop, so onlyauthDatawas affected.Test
Added a regression test in
tests/misc/test_ccache.pythat attaches an auth-data entry to a credential, serializes it, and parses it back. It fails on the current code with the AttributeError and passes with the fix. Fulltests/misc/test_ccache.py: 6 passed.