feat: enable Cmd+N shortcut in grid mode #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Cmd+N (spawn new terminal) only worked in full mode, requiring users to first expand a terminal before creating a new one. Solution: Extended the mode check for the Cmd+N handler to accept both Full and Grid modes. In grid mode, the new terminal spawns in the next available slot, inherits the focused terminal's working directory, and becomes focused in the grid view.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 890c07b4b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When the focused grid slot is unspawned, use it directly instead of searching for another free slot. This fixes a regression where pressing Cmd+N with an unspawned focused slot (and no other free slots) would incorrectly show "All terminals in use".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solution
Previously, the Cmd+N shortcut was restricted to only work in full mode (
anim_state.mode == .Full). This required users to first expand a terminal to full screen before being able to spawn a new terminal.This change extends the mode check to accept both Full and Grid modes. When used in grid mode:
Test plan
zig buildpasseszig build testpasses