lint scripts and unify assets #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Add shellcheck/ruff verification to GitHub Actions, lint the script set, move helper scripts into scripts/, and consolidate assets into the top-level assets directory. Solution: Run shellcheck and ruff from just lint and include both tools in the dev shell for CI parity. Move helper scripts and verify-setup into scripts/, update docs and CLAUDE references, and address shellcheck warnings. Relocate terminfo assets to assets/, add an assets module to embed them, and wire the new import in build and shell.
There was a problem hiding this comment.
Pull request overview
This PR consolidates linting tools and assets into a unified structure. It adds shellcheck and ruff to the linting process, relocates helper scripts and assets to dedicated directories, and embeds terminfo data through a new assets module.
Changes:
- Added shellcheck and ruff to
just lintand the Nix dev shell for CI parity - Moved helper scripts to
scripts/and updated documentation references - Created an
assets/module to embed terminfo data and updated imports inshell.zigandbuild.zig
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/shell.zig | Updated to import terminfo from the new assets module |
| scripts/bundle-macos.sh | Applied shellcheck fixes for safer variable handling and loop constructs |
| scripts/architect_notify.py | Fixed line length formatting issue |
| justfile | Added shellcheck and ruff checks to the lint recipe |
| flake.nix | Added ruff and shellcheck to dev shell dependencies |
| docs/development.md | Updated script paths to reference the new scripts/ directory |
| docs/architecture.md | Documented the new assets/ directory structure |
| build.zig | Created and imported the assets module for terminfo embedding |
| assets/terminfo.zig | New module that embeds the terminfo file |
| CLAUDE.md | Updated helper script path reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Issue: Reviewer asked to keep bash conditional syntax consistent in bundle-macos.sh. Solution: Switch remaining [ ] tests to [[ ]] to match bash-specific usage while keeping logic unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: