Open
Conversation
Fixed path issue in example file.
artfuldodger
reviewed
Jan 8, 2018
Member
artfuldodger
left a comment
There was a problem hiding this comment.
Won't these changes break the instructions for running the example? The goal of the example is to be able to see it running locally without having to make any changes to code.
cd tinymce_equation_editor
python -m SimpleHTTPServer
# open http://localhost:8000/example/example.html
Author
|
I thought this example was instruction to setup the plugin. I was thinking it would be easier for users if they could just download the plugin, drop the plugin in tinymce's plugin directory, load the plugin name in tinymce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed path issue in example file.