Conversation
Member
There was a problem hiding this comment.
Could do something like
relation = joins(association.name).merge(association.klass.send(source, *args))
relation = relation.group(grouping) if grouping
relationto reduce the bit of duplication
Author
There was a problem hiding this comment.
tried it and it broke things...i can dive in a little more next FF...and add specs :)
Member
|
👍 |
|
I like Jon's thing and of course somebody has to suggest you add a spec... 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added this to Interport this past week to add some functionality to delegate_scope so I wanted to add it here as well. Not sure if I should be doing anything with the gem version...