fix(dropdown): keep object values as string #3258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
ko2in
reviewed
May 12, 2025
Member
There was a problem hiding this comment.
It doesn't work well with encoded JSON string. https://jsfiddle.net/ko2in/ftpLscv6/
For security, the JSON object usually inserts as encoded format especially from server side like PHP htmlentities function.
Contributor
|
Kind of atk4/ui#2274 and related to #3223. The issue with this PR is "string formatted like valid JSON" will not be formatted as before - ex. input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a JSON value was used as a dropdown item value, it was internally broken as the value was casted to String resulting into
[object Object]Now, having multiple JSON values for more than 1 dropdown item the value couldn't be compared / set correctly as each values had the same
[object Object].This PR fixes it by replacing the simple castings to JSON stringify which keeps the value structure so the dropdown items keep their unique value
Testcase
Broken
https://jsfiddle.net/ReiVanBjair/ry4123z0/11/
Fixed
https://jsfiddle.net/lubber/L0ysfoqj/
Screenshots
Broken
Fixed
Closes
#3005