Skip to content

Conversation

@julianladisch
Copy link
Contributor

@julianladisch julianladisch commented Jun 5, 2025

https://folio-org.atlassian.net/browse/OKAPI-1213

In Vert.x 5 it’s no longer possible to call putLocal with a String key, it must be a ContextLocal key: https://vertx.io/docs/guides/vertx-5-migration-guide/#_context_local_storage_changes

The ContextLocal keys are defined in FolioLocal: https://github.com/folio-org/okapi/blob/master/okapi-common/src/main/java/org/folio/okapi/common/logging/FolioLocal.java

This change allows modules to directly use the key defined in FolioLocal when writing a value into the local context. This avoids a lookup that requires a call to FolioLocalContext.localKey:

ctx.putLocal(localKey(key), value);
} else {
ctx.removeLocal(localKey(key));

@sonarqubecloud
Copy link

@julianladisch julianladisch merged commit 5eb864f into master Jun 24, 2025
7 checks passed
@julianladisch julianladisch deleted the OKAPI-1213 branch June 24, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants