OKAPI-1212: okapi-common: Upgrade to Vert.x 5 #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://folio-org.atlassian.net/issues/OKAPI-1212 The shared library okapi-common needs to migrate Vertx from 4 to 5. It’s required for Trillium: https://folio-org.atlassian.net/wiki/spaces/TC/pages/730891059/Trillium#Trillium-ThirdPartyLibraries/Frameworks See migration guide: https://folio-org.atlassian.net/wiki/spaces/FOLIJET/pages/1003847853/Migration+to+Vertx+5
steveellis
reviewed
May 27, 2025
steveellis
reviewed
May 27, 2025
steveellis
approved these changes
May 27, 2025
Contributor
steveellis
left a comment
steveellis
left a comment
There was a problem hiding this comment.
Thanks for taking care of this Julian!
|
Contributor
|
@julianladisch @steveellis guys, this PR is misleading, it's certainly much more than upgrading to vert.x 5. @julianladisch can you please revert this? If you want to avoid porting entire Okapi to vert.x 5 please create a new repo just for okapi-common. But check with @adamdickmeiss first, he expressed that he'd be willing to port the entire codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/issues/OKAPI-1212
The shared library okapi-common needs to migrate Vertx from 4 to 5.
It’s required for Trillium: https://folio-org.atlassian.net/wiki/spaces/TC/pages/730891059/Trillium#Trillium-ThirdPartyLibraries/Frameworks
See migration guide: https://folio-org.atlassian.net/wiki/spaces/FOLIJET/pages/1003847853/Migration+to+Vertx+5
FOLIO adopots the Eureka platform: https://folio-org.atlassian.net/wiki/spaces/TC/pages/518946885/0010-eureka
Eureka no longer needs and no longer uses the Okapi server.
Therefore the okapi-core directory (= Okapi server) and all server related content is dropped in this PR.