Skip to content

MODLD-1011: Fix the relation URLs to match with the URLs defined in https://bibfra.me/vocab/relation#160

Merged
pkjacob merged 1 commit intomasterfrom
pjacob/MODLD-1011
Mar 12, 2026
Merged

MODLD-1011: Fix the relation URLs to match with the URLs defined in https://bibfra.me/vocab/relation#160
pkjacob merged 1 commit intomasterfrom
pjacob/MODLD-1011

Conversation

@pkjacob
Copy link
Contributor

@pkjacob pkjacob commented Mar 11, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 11, 2026 14:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates PredicateDictionary relation IRIs to match the canonical URLs defined in https://bibfra.me/vocab/relation, aligning internal predicate resolution with the external vocabulary.

Changes:

  • Normalize many PredicateDictionary relation URIs (primarily casing/format) to match bibfra.me’s canonical forms.
  • Expand the PredicateDictionaryTest URI/hash parameter set to cover the updated predicate URIs.
  • Add a NEWS entry documenting the MODLD-1011 change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/main/java/org/folio/ld/dictionary/PredicateDictionary.java Updates many predicate URIs to canonical bibfra.me relation URL forms.
src/test/java/org/folio/ld/dictionary/PredicateDictionaryTest.java Updates/expands parameterized test data to reflect the new canonical URIs and their hashes.
NEWS.md Adds release note entry for MODLD-1011.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pkjacob pkjacob force-pushed the pjacob/MODLD-1011 branch from f776ca7 to 643b15d Compare March 11, 2026 16:00
@sonarqubecloud
Copy link

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pkjacob pkjacob merged commit 9f1f259 into master Mar 12, 2026
5 checks passed
@pkjacob pkjacob deleted the pjacob/MODLD-1011 branch March 12, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants