MODLD-1002 Update predicate dictionary relations#158
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the linked-data predicate vocabulary to reflect new/renamed bibfra.me relation predicates, and keeps test coverage and release notes in sync with the dictionary changes.
Changes:
- Added new
PredicateDictionaryentries:ADAPTED_AS_MOTION_PICTURE,IS_TRANSLATION_OF,RELATED_WORK,SEQUEL,SEQUEL_TO. - Removed
RELATED_TOfromPredicateDictionary. - Updated
PredicateDictionaryTestCSV cases andNEWS.mdto reflect the predicate changes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/main/java/org/folio/ld/dictionary/PredicateDictionary.java |
Adds/removes predicate enum entries (URIs + derived hashes). |
src/test/java/org/folio/ld/dictionary/PredicateDictionaryTest.java |
Updates parameterized test cases to include the new predicate URIs and hashes. |
NEWS.md |
Documents the predicate dictionary update for the in-progress v2.0.0 release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/org/folio/ld/dictionary/PredicateDictionaryTest.java
Outdated
Show resolved
Hide resolved
pkjacob
force-pushed
the
pjacob/MODLD-1002
branch
from
9162233 to
508bb09
Compare
pkjacob
force-pushed
the
pjacob/MODLD-1002
branch
from
8dd936b to
86fbc8f
Compare
|
zepheiryan
approved these changes
Mar 5, 2026
PBobylev
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.