This repository was archived by the owner on Jul 19, 2025. It is now read-only.
keep packaging version constant on dev and release#137
Merged
fohrloop merged 1 commit intofohrloop:devfrom Aug 19, 2024
Merged
Conversation
2 tasks
Owner
|
Hey @mapix , I'm unable to setup the development environment. I mean, I don't have time to learn how to tackle the problems with Node and I'm not a JS developer, so I just take your word on that the tests pass. As a side note, would be helpful to improve the CONTRIBUTING.md on how to setup the dev env (so people not familiar with JS ecosystem would feel that it's easy to contribute), and also would be cool if this project would have a CI pipeline which would run basic tests. Thanks a lot for writing the PRs!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since packaging==21.0 passed all tests (except for this PR) on the current codebase, let's keep the development version consistent with the release environment."