86b7h2jgh - Fix: add asterisks to mandatory fields on add new item form #743
+21
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarcet
reviewed
Jan 19, 2026
| "standard_rate": "Standard rate", | ||
| "onsite_rate": "On site rate", | ||
| "default_quantity": "Default quantity", | ||
| "name": "Name *", |
There was a problem hiding this comment.
@niko-exo i do thnk that i would be better to update the fields like
https://github.com/fntechgit/summit-admin/blob/cf8c1749e92a5c08b60bf5803010a63e9417e5d0/src/components/mui/formik-inputs/mui-formik-textfield.js to support the required attr instead of change labels
smarcet
reviewed
Jan 19, 2026
| early_bird_rate: decimalValidation(), | ||
| standard_rate: decimalValidation(), | ||
| onsite_rate: decimalValidation(), | ||
| early_bird_rate: decimalValidation().required( |
There was a problem hiding this comment.
@niko-exo please rebase against main and review
we already addd required to decimal validation
smarcet
reviewed
Jan 19, 2026
| onsite_rate: decimalValidation().required( | ||
| T.translate("validation.required") | ||
| ), | ||
| default_quantity: numberValidation() |
There was a problem hiding this comment.
@niko-exo also please check this
default_quantity: positiveNumberValidation(),
quantity_limit_per_sponsor: positiveNumberValidation(),
quantity_limit_per_show: positiveNumberValidation(),
meta_fields: formMetafieldsValidation()
smarcet
requested changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b7h2jgh
86b7h2jgh - Fix: add asterisks to mandatory fields on add new item form
Changelog
Links
86b7h2jgh - Add asterisks to mandatory fields
Evidence
2026-01-05_10-16-31.mp4