-
Notifications
You must be signed in to change notification settings - Fork 4
86b7yxuzh - fix: close modal on succesful approval #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| fetchResponseHandler, | ||
| fetchErrorHandler | ||
| } from "openstack-uicore-foundation/lib/utils/actions"; | ||
| import * as _ from "lodash"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niko-exo why do we need this ?
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niko-exo please review comments
Signed-off-by: sebastian marcet <[email protected]>
|
LGTM |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughLodash imports are migrated from default to namespace syntax across three action files. A new test suite with comprehensive mock data is added for the ProcessRequestPopup component. The component's save handler is made asynchronous to await sponsor user request processing before closing the dialog. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Poem
✨ Finishing touches
Comment |
ref: https://app.clickup.com/t/86b7yxuzh
86b7yxuzh - fix: close modal on succesful approval
Changelog
Link
86b7yxuzh - Sponsor users - Show Level - Access Request Approval - Modal should be closed after a successful approval
Evidence
2025-12-31_14-35-51.mp4
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.