Skip to content

fix: stop clobbering root logger #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: stop clobbering root logger #141

wants to merge 2 commits into from
+5 −3

Conversation

tabrezm
Copy link

@tabrezm tabrezm commented Nov 10, 2024

Proposed fix for #114 by:

  1. Setting the root logger to debug only when fdk itself is running in debug mode.
  2. Move the StreamHandler to the fdk logger to play nice with apps using fdk and the root logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tabrezm