Skip to content

[WIP] Adding various NodeJS runtimes #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Adding various NodeJS runtimes #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7538d42
various node runtimes
denismakogon Mar 12, 2019
efb053d
reorder node runtime versions
denismakogon Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion langs/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ func init() {
registerHelper(&GoLangHelper{})
registerHelper(&JavaLangHelper{version: "8"})
registerHelper(&JavaLangHelper{version: "11"})
registerHelper(&NodeLangHelper{})
registerHelper(&NodeLangHelper{Version: "11"})
registerHelper(&NodeLangHelper{Version: "10"})
registerHelper(&NodeLangHelper{Version: "8"})
registerHelper(&PythonLangHelper{Version: "3.6"})
registerHelper(&PythonLangHelper{Version: "3.7.1"})
registerHelper(&RubyLangHelper{})
Expand Down
10 changes: 7 additions & 3 deletions langs/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
package langs

import (
"fmt"
"io/ioutil"
"os"
"path/filepath"
)

type NodeLangHelper struct {
BaseHelper
Version string
}

func (h *NodeLangHelper) Handles(lang string) bool {
Expand All @@ -18,18 +20,20 @@ func (h *NodeLangHelper) Runtime() string {
}

func (lh *NodeLangHelper) LangStrings() []string {
return []string{"node"}
return []string{"node", fmt.Sprintf("node%s", lh.Version)}
}

func (lh *NodeLangHelper) Extensions() []string {
// this won't be chosen by default
return []string{".js"}
}

func (lh *NodeLangHelper) BuildFromImage() (string, error) {
return "fnproject/node:dev", nil
return fmt.Sprintf("fnproject/node:%s-dev", lh.Version), nil
}

func (lh *NodeLangHelper) RunFromImage() (string, error) {
return "fnproject/node", nil
return fmt.Sprintf("fnproject/node:%s", lh.Version), nil
}

const funcJsContent = `const fdk=require('@fnproject/fdk');
Expand Down