feat: migrate I/O operations to core/ with Result types - #151
Merged
Conversation
- Create modern I/O interface with Result-based error handling - All I/O operations now return Result types for explicit error handling - Comprehensive test coverage for file, directory, filesystem, and process operations - Zero warnings achieved with strict C23 compiler flags - Delete legacy io_default.c and io_ops.h from src/
- Fix memory leaks by freeing error objects in tests - Fix naming conventions (CamelCase for struct constants) - Add NOLINT for feature test macros - Remove unused error.h include from io.h - Add missing includes for types (result.h, sys/types.h) - Suppress cert-env33-c warning for system() function
flyingrobots
force-pushed
the
fix/warnings
branch
from
July 8, 2025 19:55
441d939 to
a8a5c35
Compare
- Added gm_error_free() calls for all error cases in test_io.c - Fixed test_file_operations error handling (line 94) - Fixed test_dir_operations error handling (line 132) - Fixed test_fs_operations error handling (line 194) - Replaced threads.h with pthread.h for macOS compatibility - Changed thrd_sleep to nanosleep for POSIX compliance - All tests now pass with zero memory leaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test Results
All 10 tests pass, zero warnings in clang-tidy.
🤖 Generated with Claude Code