fix(framework): Fix serverapp heartbeat simulation assertions for shared app process#6863
Closed
fix(framework): Fix serverapp heartbeat simulation assertions for shared app process#6863
Conversation
…ared app process Signed-off-by: Patrick Foley <patrick@flower.ai>
psfoley
requested review from
danieljanes,
panh99 and
tanertopal
as code owners
psfoley
changed the title
Signed-off-by: Patrick Foley <patrick@flower.ai>
psfoley
changed the title
psfoley
changed the title
psfoley
changed the title
github-actions
bot
added
the
Maintainer
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ServerApp heartbeat E2E test to accommodate simulation environments where multiple runs may share the same underlying app process, affecting expected terminal statuses after killing an app process.
Changes:
- Capture all matching app-process PID(s) after the first run starts instead of a single PID.
- Delay selecting the PID to kill until after both runs are confirmed running.
- Relax run2 terminal-status assertions in simulation mode to allow
FAILEDas an acceptable outcome.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
No longer necessary after #6858 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.