runtime/controller: add support for detecting enqueue events while reconciling #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuscscp
added
the
area/runtime
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
Let's use interrupt to be explicit to consumers what this context should be used for.
matheuscscp
force-pushed
the
add-queue
branch
6 times, most recently
from
4f69e98 to
0b339b5
Compare
…conciling Signed-off-by: Matheus Pimenta <[email protected]>
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
force-pushed
the
add-queue
branch
from
0b339b5 to
062fd8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: fluxcd/flux2#5584
xref: kubernetes-sigs/controller-runtime#3334
This PR introduces a wrapper for the controller-runtime reconciler interface and for the controller builder to enhance them with the ability of detecting requeue events inside a reconciliation. This is useful for downstream controllers to cancel ongoing long-running operations and let a new reconciliation start sooner.
This has been tested in an EKS cluster with this example usage in kustomize-controller:
fluxcd/kustomize-controller#1536